Do you have to return your old phone when you get an upgrade?

No, you own the phone now and can choose whether to keep it or sell it. Sometimes it can be useful to have a spare phone as a back-up phone for your new one.